[Hungle2911]

Motivation

Close #2968
The current block conversion from do..end to brackets fails when handling complex data structures like Hashes or Arrays. Simply converting line breaks to semicolons doesn't maintain code validity in these cases.

Implementation

• Added remove_newlines_in_brackets method to properly handle newlines within Hash/Array literals

Automated Tests

1. test_toggle_block_do_end_to_brackets: Verifies basic block conversion functionality
2. test_toggle_block_do_end_with_hash_to_brackets: Ensures proper handling of Hash literals within blocks

[vinistock]

This approach is essentially re-parsing the string that was already parsed by Prism to remove the newlines. I'm concerned that this will be quite error prone, since parsing Ruby is challenging.

For example, will the code work properly in a case like this?

[].each do |something|
  # Brackets that don't represent an array mixed with arrays
  a[:hello] = [
    something[1],
  ]
end

If we could find a way to use the already parsed nodes from Prism to rebuild the block's body, I think that would be more robust. Maybe we need to go through the nodes inside the body and transform them into single line one by one, with different rules for hash and array nodes so that we can produce valid code.

[github-actions]

This pull request is being marked as stale because there was no activity in the last 2 months