Skip to content

Commit

Permalink
Merge pull request #172 from Shopify/bugfix/remove-deps-check-npm-build
Browse files Browse the repository at this point in the history
Removed checking android deps through configuration
  • Loading branch information
chrfalch authored Feb 2, 2022
2 parents 11eb2a2 + dbb471e commit 590f9e3
Showing 1 changed file with 15 additions and 14 deletions.
29 changes: 15 additions & 14 deletions scripts/build-npm-package.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import {
} from "./utils";
import fs from "fs";
import { exit } from "process";
import { configurations } from "./skia-configuration";

const pck = JSON.parse(fs.readFileSync("./package/package.json").toString());

Expand Down Expand Up @@ -38,20 +37,22 @@ if (process.env.GITHUB_RUN_NUMBER === undefined) {
}

// Check that Android Skia libs are built
Object.keys(configurations.android.targets).forEach((targetKey) => {
const target = configurations.android.targets[targetKey];
configurations.android.outputNames.forEach((name) => {
const path = `./package/libs/android/${
target.output ?? target.cpu
}/${name}`;
// SKIP for now since we can't use configuration here since it depends on
// iPhone SDKs that we get from xcrun... TODO!
// Object.keys(configurations.android.targets).forEach((targetKey) => {
// const target = configurations.android.targets[targetKey];
// configurations.android.outputNames.forEach((name) => {
// const path = `./package/libs/android/${
// target.output ?? target.cpu
// }/${name}`;

checkFileExists(
path,
`Skia Android ${path}`,
"Have you built the Skia Android binaries? Run yarn run build."
);
});
});
// checkFileExists(
// path,
// `Skia Android ${path}`,
// "Have you built the Skia Android binaries? Run yarn run build."
// );
// });
// });

// Check that iOS Skia frameworks are built
[
Expand Down

0 comments on commit 590f9e3

Please sign in to comment.