Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small CI fixes #54

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Small CI fixes #54

merged 2 commits into from
Apr 4, 2024

Conversation

paracycle
Copy link
Member

Mostly fixing the problems seen here

Node.js 16 actions are deprecated, so we need to use v4 of the `actions/checkout` action to avoid the deprecation warning.
When one of the matrix elements is not supplied an explicit value in an `include` block, the value for that element is cleared. As a result, our build matrix never knew which machine to run the build on for Ruby 3.3 builds, since the `os` value was being cleared.
@caution-tape-bot
Copy link

👋 It seems that this PR is adding, or editing, a GitHub Action workflow that is not configured to use our custom GitHub Action runners.

For private repositories, the only supported way of running Action workflows is via the custom runners. You can learn more about the supported use cases in our GitHub Actions documentation.

To make sure that your workflow is using these runners you need to add the shopify-ubuntu-latest label to your workflow manifest file, or shopify-core-ubuntu-latest for Core repositories:

runs-on: shopify-ubuntu-latest

If your repository is intended to become Public later, please use runs-on: shopify-ubuntu-latest for now. The custom runners should function the same as ubuntu-latest public runners, though the exact Ubuntu version may vary. Please see the section below for more information about OS selection on premium runners.

If you run into any issues with the custom runners, please reach out in help-eng-infrastructure on Discourse.

Note for OS Versions

The shopify-ubuntu-latest runners can select from two different runner pools, which contain both Ubuntu 20.04 and Ubuntu 22.04 machines. For some workflows, this can cause issues.

To use Ubuntu 20.04 only, you can specify runs-on: shopify-ubuntu-20.04.

To use Ubuntu 22.04 only, you can specify runs-on: shopify-ubuntu-latest-2.


This comment was added by the GitHubActions::Workflow Caution Tape Bot rule.
View the source of this rule in Services DB

@maximecb maximecb merged commit a9a0a86 into main Apr 4, 2024
8 checks passed
@maximecb maximecb deleted the uk-fix-action-versions branch April 4, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants