Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable benchmark-ips baseline comparison #45

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Conversation

casperisfine
Copy link

This ensure that the first defined code block is the one all others are compared to. Makes the output much more readable in my opinion.

Before:

Comparison:
decode and read protoboeuf:       22.9 i/s
decode and read upstream:        5.7 i/s - 4.04x  slower

After:

Comparison:
decode and read upstream:        6.1 i/s
decode and read protoboeuf:       29.6 i/s - 4.88x  faster

This ensure that the first defined code block is the one all
others are compared to. Makes the output much more readable
in my opinion.

Before:

```
Comparison:
decode and read protoboeuf:       22.9 i/s
decode and read upstream:        5.7 i/s - 4.04x  slower
```

After:

```
Comparison:
decode and read upstream:        6.1 i/s
decode and read protoboeuf:       29.6 i/s - 4.88x  faster
```
Copy link
Contributor

@maximecb maximecb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change 👍

@maximecb maximecb merged commit 699d84f into main Apr 4, 2024
4 checks passed
@maximecb maximecb deleted the ips-compare-baseline branch April 4, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants