Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature, Update Grid responsiveness behavior and fix Tooltips overflow cuts #1754

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Passanelli
Copy link
Collaborator

What does this implement/fix?

Update responsiveness breakpoints and paddings to avoid render empty values on groups cells
Move outside element to make visible outside viewport
Update mock data implementation to get random values on each render

Does this close any currently open issues?

Closes:
issue #1
issue #2
issue #3

What do the changes look like?

Storybook link

Tophat link url

Before merging

  • Check your changes on a variety of browsers and devices.

  • Update the Changelog's Unreleased section with your changes.

  • Update relevant documentation, tests, and Storybook.

  • Make sure you're exporting any new shared Components, Types and Utilities from the top level index file of the package

@Passanelli Passanelli self-assigned this Nov 12, 2024
Copy link

github-actions bot commented Nov 12, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
polaris-viz-core-cjs 61.63 KB (0%) 1.3 s (0%) 859 ms (-35.65% 🔽) 2.1 s
polaris-viz-cjs 222.72 KB (+0.06% 🔺) 4.5 s (+0.06% 🔺) 2.2 s (+22.03% 🔺) 6.7 s
polaris-viz-esm 180.65 KB (+0.11% 🔺) 3.7 s (+0.11% 🔺) 1.4 s (-13.19% 🔽) 5 s
polaris-viz-css 5.52 KB (+0.86% 🔺) 111 ms (+0.86% 🔺) 309 ms (+27.35% 🔺) 420 ms
polaris-viz-esnext 187.37 KB (+0.14% 🔺) 3.8 s (+0.14% 🔺) 1.5 s (+19.55% 🔺) 5.3 s

@Passanelli Passanelli force-pushed the passanelli/grid_responsiveness_updates branch 3 times, most recently from e7ce1c7 to 7e596ae Compare November 14, 2024 15:59
@Passanelli Passanelli force-pushed the passanelli/grid_responsiveness_updates branch from 7e596ae to 59c377a Compare November 14, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant