WIP: Set LineChart Tooltip at static Y when on touch device #1750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
envex
changed the title
envex
changed the title
envex
force-pushed
the
envex/static-mobile-tooltips
branch
from
e65dd72
to
c557c3b
Compare
carysmills
reviewed
Nov 7, 2024
There was a problem hiding this comment.
This generally feels really good to me 🎉 I would like to try the scrolling part in the context of the admin, but I think the tooltip changes work really well. We'd probably want the exact same for area chart and I am not super sure what the behaviour should be for bar charts, probably about the same?
| @@ -243,9 +251,11 @@ export function Chart({ | |||
| max: data[longestSeriesIndex].data.length - 1, | |||
| }); | |||
|
|
|||
| const {x, y} = getXYFromEventType(event); | |||
There was a problem hiding this comment.
At some point, not necessarily now, I think it would be nice to consolidate some of the tooltip positioning logic. I'm mostly thinking of what's in this function, what's in getAlteredPosition and what's in the actual tooltip component and whether there's a way to simplify it all a bit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
When on a touch device we want the
LineCharttooltip to always display above the chart instead of under the users finger.Storybook link
https://6062ad4a2d14cd0021539c1b-bgueplbuui.chromatic.com/iframe.html?args=&id=polaris-viz-charts-linechart-playground--external-tooltip&viewMode=story
MobileBefore merging
Check your changes on a variety of browsers and devices.
Update the Changelog's Unreleased section with your changes.
Update relevant documentation, tests, and Storybook.
Make sure you're exporting any new shared Components, Types and Utilities from the top level index file of the package