Add resource_limits support to spec runner#132
Merged
Conversation
- Add resource_limits to VALID_SPEC_KEYS and LazySpec (attr_reader + param) - Pass raw_resource_limits through SpecLoader to LazySpec.new - Include resource_limits in render_options in cli/runner.rb - Apply limits via Liquid::ResourceLimits in the liquid_ruby.rb adapter - Add specs/basics/resource-limits.yml with three cumulative/per-template tests
ianks
changed the title
ianks
changed the title
resource_limits support to spec runner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a `resource_limits:` key to spec YAML so adapters can test Liquid's
resource limit enforcement.
How it works
`cumulative_render_score_limit`, etc.)
`render_options[:resource_limits]`
instance and pass it to `Context.build`
cumulative limits across partials, and the "limits not triggered when unset" case
Also includes a `deep_instantiate` fix — drop class names with trailing colons
(e.g. `'instantiate:LiquidDropClass:'`) weren't being looked up correctly in
`ClassRegistry` because `key.sub("instantiate:", "")` left the trailing colon
intact. Added `.chomp(":")` to normalize both the quoted and unquoted YAML formats.