Fix deep_instantiate to strip trailing colon from class name#131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
yaml_coders.rbencode_withmethods serialize drops using a hash key like"instantiate:LiquidDropClass:"(trailing colon intentional, mirrors the unquoted YAML format). When YAML dumps a key ending in:, it quotes the whole string, preserving the trailing colon. Whendeep_instantiatereads it back,key.sub("instantiate:", "")leaves"LiquidDropClass:"with the trailing colon intact, soClassRegistry.instantiatecan't find it and silently falls through, leaving the raw hash in the template context.The unquoted format (
instantiate:LongString:) works fine because YAML treats the final:as the mapping separator, not part of the key.Fix: add
.chomp(":")after prefix removal. It's a no-op for the unquoted form.