Add specs for bare-bracket rejection in strict2 and self keyword#124
Open
aswamy wants to merge 1 commit into
Open
Add specs for bare-bracket rejection in strict2 and self keyword#124aswamy wants to merge 1 commit into
self keyword#124aswamy wants to merge 1 commit into
Conversation
- strict2 rejects bare-bracket access (['product'], [key], etc.) - Qualified bracket access (product['title']) remains valid - `self` keyword resolves variables through the scope chain - `self` works in all parsing modes (lax, strict, strict2) - Local assigns shadow the `self` keyword Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
5a98157 to
c841a82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds conformance specs for the bare-bracket syntax changes in Shopify/liquid (28 specs total).
Bare-bracket rejection in strict2 (7 specs):
{{ ['product'] }},{{ [key] }}are rejected withparse_errorfor,if,case,assignstrict2 accepts qualified access (2 specs):
product['title']and dot notation remain validselfkeyword (18 specs):self['product']resolves variables through the normal scope chainself[key]performs dynamic variable lookups (key from environment OR local assign)self['product']selfcan be reassigned ({% assign self = 'value' %})self['product'].title)a[ self[ 'b' ] ],self[self['key1']]forloop bodies andcaptureblocksselfkeyword still resolves to SelfDrop even when environment defines aselfkeyself contains 'key'always returns false becausecontainscallsinclude?and SelfDrop doesn't implement it — useself['key']for definedness checksBackwards compatibility (1 spec):
Depends on:
🤖 Generated with Claude Code