[WIP] chore(eslint): upgrade eslint to v9

docs/preview/package.json

@@ -20,13 +20,12 @@
   },
   "devDependencies": {
     "@remix-run/dev": "^2.15.2",
-    "@remix-run/eslint-config": "^2.15.2",
     "@tailwindcss/vite": "4.0.0-beta.8",
     "@types/he": "^1.2.1",
     "@types/react": "^18.2.20",
     "@types/react-dom": "^18.2.7",
     "@types/react-syntax-highlighter": "^15.5.7",
-    "eslint": "^8.38.0",
+    "eslint": "^9.18.0",
     "typescript": "^5.2.2",
     "vite": "^5.1.8",
     "vite-tsconfig-paths": "^4.3.1"

eslint.config.js

@@ -0,0 +1,49 @@
+const typescriptParser = require('@typescript-eslint/parser');
+const typescriptPlugin = require('@typescript-eslint/eslint-plugin');
+
+/** @type {import('eslint').Flat.Config[]} */
+module.exports = [
+  {
+    ignores: [
+      'build/',
+      'node_modules/',
+      'bin/',
+      '*.d.ts',
+      'dist/',
+      'coverage/',
+      'packages/hydrogen-react/codegen.ts',
+      'packages/hydrogen-react/vite.config.ts',
+      'packages/hydrogen-react/vitest.setup.ts',
+    ],
+  },
+  {
+    files: ['**/*.{js,jsx,ts,tsx}'],
+    settings: {
+      'import/resolvers': {
+        typescript: {
+          project: ['packages/*/tsconfig.json', 'templates/*/tsconfig.json'],
+        },
+      },
+    },
+    languageOptions: {
+      parser: typescriptParser,
+      parserOptions: {
+        ecmaVersion: 'latest',
+        sourceType: 'module',
+      },
+    },
+    linterOptions: {
+      reportUnusedDisableDirectives: false,
+    },
+    plugins: {
+      '@typescript-eslint': typescriptPlugin,
+    },
+    rules: {
+      '@typescript-eslint/ban-ts-comment': 'off',
+      '@typescript-eslint/naming-convention': 'off',
+      '@typescript-eslint/no-non-null-asserted-optional-chain': 'off',
+      'no-useless-escape': 'off',
+      'no-case-declarations': 'off',
+    },
+  },
+];

examples/express/app/entry.server.tsx

@@ -9,7 +9,7 @@ import {PassThrough} from 'node:stream';
 import type {AppLoadContext, EntryContext} from '@remix-run/node';
 import {Response} from '@remix-run/web-fetch';
 import {RemixServer} from '@remix-run/react';
-import isbot from 'isbot';
+import isbotua from 'isbot';
 import {renderToPipeableStream} from 'react-dom/server';
 import {createContentSecurityPolicy} from '@shopify/hydrogen';
 
@@ -22,7 +22,7 @@ export default function handleRequest(
   remixContext: EntryContext,
   loadContext: AppLoadContext,
 ) {
-  return isbot(request.headers.get('user-agent'))
+  return isbotua(request.headers.get('user-agent'))
     ? handleBotRequest(
         request,
         responseStatusCode,

examples/express/eslint.config.js

@@ -0,0 +1,111 @@
+import js from '@eslint/js';
+import reactPlugin from 'eslint-plugin-react';
+import reactHooksPlugin from 'eslint-plugin-react-hooks';
+import jsxA11yPlugin from 'eslint-plugin-jsx-a11y';
+import tsPlugin from '@typescript-eslint/eslint-plugin';
+import tsParser from '@typescript-eslint/parser';
+import importPlugin from 'eslint-plugin-import';
+import globals from 'globals';
+
+export default [
+  // Base configuration for all files
+  {
+    ignores: ['!**/.server/**', '!**/.client/**'],
+  },
+  js.configs.recommended,
+
+  // JavaScript/JSX files configuration
+  {
+    files: ['**/*.{js,jsx,ts,tsx}'],
+    languageOptions: {
+      ecmaVersion: 'latest',
+      globals: {
+        ...globals.browser,
+        ...globals.commonjs,
+      },
+    },
+    plugins: {
+      react: reactPlugin,
+      'react-hooks': reactHooksPlugin,
+      'jsx-a11y': jsxA11yPlugin,
+    },
+    settings: {
+      react: {
+        version: 'detect',
+      },
+      formComponents: ['Form'],
+      linkComponents: [
+        {name: 'Link', linkAttribute: 'to'},
+        {name: 'NavLink', linkAttribute: 'to'},
+      ],
+      'import/resolver': {
+        typescript: {},
+      },
+    },
+    rules: {
+      ...reactPlugin.configs.recommended.rules,
+      ...reactPlugin.configs['jsx-runtime'].rules,
+      ...reactHooksPlugin.configs.recommended.rules,
+      ...jsxA11yPlugin.configs.recommended.rules,
+    },
+  },
+
+  // TypeScript files configuration
+  {
+    files: ['**/*.{ts,tsx}'],
+    plugins: {
+      '@typescript-eslint': tsPlugin,
+      import: importPlugin,
+    },
+    languageOptions: {
+      parser: tsParser,
+      globals: {
+        React: 'readonly',
+      },
+      parserOptions: {
+        project: './tsconfig.json',
+        ecmaVersion: 'latest',
+        sourceType: 'module',
+      },
+    },
+    settings: {
+      'import/internal-regex': '^~/',
+      'import/resolver': {
+        typescript: {
+          alwaysTryTypes: true,
+          project: './tsconfig.json',
+        },
+        node: {
+          extensions: ['.ts', '.tsx', '.js', '.jsx'],
+        },
+      },
+    },
+    rules: {
+      ...tsPlugin.configs.recommended.rules,
+      ...importPlugin.configs.recommended.rules,
+      ...importPlugin.configs.typescript.rules,
+      '@typescript-eslint/no-empty-object-type': 'off',
+    },
+  },
+
+  // Node environment configuration
+  {
+    files: ['eslint.config.js'],
+    languageOptions: {
+      sourceType: 'module',
+      ecmaVersion: 'latest',
+      globals: {
+        node: true,
+      },
+    },
+  },
+
+  {
+    files: ['**/*.mjs'], // For Node.js ESM files
+    languageOptions: {
+      globals: {
+        ...globals.node,
+      },
+    },
+  },
+];

examples/express/package.json

@@ -24,16 +24,24 @@
     "react-dom": "^18.2.0"
   },
   "devDependencies": {
+    "@eslint/js": "^9.18.0",
     "@remix-run/dev": "^2.15.2",
-    "@remix-run/eslint-config": "^2.15.2",
     "@shopify/cli": "~3.73.0",
     "@types/compression": "^1.7.2",
     "@types/express": "^4.17.17",
     "@types/morgan": "^1.9.4",
     "@types/react": "^18.2.22",
     "@types/react-dom": "^18.2.7",
+    "@typescript-eslint/eslint-plugin": "^8.21.0",
+    "@typescript-eslint/parser": "^8.21.0",
     "dotenv": "^16.0.3",
-    "eslint": "^8.38.0",
+    "eslint": "^9.18.0",
+    "eslint-import-resolver-typescript": "^3.7.0",
+    "eslint-plugin-import": "^2.31.0",
+    "eslint-plugin-jsx-a11y": "^6.10.2",
+    "eslint-plugin-react": "^7.37.4",
+    "eslint-plugin-react-hooks": "^5.1.0",
+    "globals": "^15.14.0",
     "nodemon": "^2.0.22",
     "npm-run-all": "^4.1.5",
     "typescript": "^5.2.2",