Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated components codes #2601

Merged
merged 4 commits into from
Oct 21, 2024
Merged

Conversation

wizardlyhel
Copy link
Contributor

WHY are these changes introduced?

Remove code for deprecation warning and the deprecated field fallbacks

  • Remove fallback usage for priceV2 and compareAtPriceV2
  • Remove export for getCustomerPrivacy

WHAT is this pull request doing?

HOW to test your changes?

Post-merge steps

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

Copy link
Contributor

shopify bot commented Oct 11, 2024

Oxygen deployed a preview of your hl-remove-component-deprecations branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment October 14, 2024 9:39 AM
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment October 14, 2024 9:39 AM
classic-remix ✅ Successful (Logs) Preview deployment Inspect deployment October 14, 2024 9:39 AM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment October 14, 2024 9:39 AM
metaobjects ✅ Successful (Logs) Preview deployment Inspect deployment October 14, 2024 9:39 AM
sitemap ✅ Successful (Logs) Preview deployment Inspect deployment October 14, 2024 9:39 AM

Learn more about Hydrogen's GitHub integration.

@@ -6,7 +6,7 @@ const data: ReferenceEntityTemplateSchema = {
isVisualComponent: false,
related: [],
description:
'A hook that loads the [Customer Privacy API](/docs/api/customer-privacy).\n\nYou can get the customer privacy instance with `getCustomerPrivacy()`.\n\nYou can also listen to a `document` event for `shopifyCustomerPrivacyApiLoaded`. It will be emitted when the Customer Privacy API is loaded.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this reference still existed in the docs, so I've removed it

@wizardlyhel wizardlyhel merged commit 8c89f29 into main Oct 21, 2024
13 checks passed
@wizardlyhel wizardlyhel deleted the hl-remove-component-deprecations branch October 21, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants