Fix the OptimisticCart type to properly retain the generic of line items
#2327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
blittle
commented
Jul 12, 2024
Comment on lines
-68
to
+70
| lines: OptimisticCartLine[]; | ||
| lines: CartLine[]; |
There was a problem hiding this comment.
Needed to change, because just using the OptimisticCartLine directly without a generic means the default API query is used.
blittle
commented
Jul 12, 2024
blittle
commented
Jul 12, 2024
Comment on lines
+25
to
+32
| #/***********************************************/ | ||
| #/********** EXAMPLE UPDATE STARTS ************/ | ||
| sellingPlanAllocation { | ||
| sellingPlan { | ||
| name | ||
| } | ||
| } | ||
| #/***********************************************/ |
There was a problem hiding this comment.
Adding sellingPlanAllocation here.
blittle
force-pushed
the
bl-fix-optimistic-cart-types-2
branch
2 times, most recently
from
b8c908a
to
a67a4dd
Compare
|
/snapit |
|
🫰✨ Thanks @blittle! Your snapshot has been published to npm. Test the snapshot by updating your "@shopify/hydrogen": "0.0.0-snapshot-20240712202726" |
frandiox
reviewed
Jul 16, 2024
frandiox
reviewed
Jul 29, 2024
blittle
force-pushed
the
bl-fix-optimistic-cart-types-2
branch
from
a0a9965
to
d4e17c7
Compare
|
I've experienced this as well! Would love to see it come in the next release :) |
frandiox
approved these changes
Jul 31, 2024
blittle
commented
Jul 31, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
@brookslybrand reported an issue where the the generic on
OptimisticCartdid not propagate to line items. For example, this would produce a type of the default cart lines, not the generic api fragment provided.With this change, now the
CartAPIQueryFragmentis preserved.Checklist