createWithCache's request param is now required

Shopify · Oct 22, 2024 · 19fd3cf · 19fd3cf
1 parent f0e1845
commit 19fd3cf
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/hydrogen/src/cache/create-with-cache.test.ts b/packages/hydrogen/src/cache/create-with-cache.test.ts
@@ -17,7 +17,7 @@ describe('createWithCache', () => {
   beforeEach(() => {
     vi.useFakeTimers();
     cache = new InMemoryCache();
-    withCache = createWithCache({cache, waitUntil});
+    withCache = createWithCache({cache, waitUntil, request: {headers: {}}});
     waitUntil.mockClear();
     return () => vi.useRealTimers();
   });

diff --git a/packages/hydrogen/src/cache/create-with-cache.ts b/packages/hydrogen/src/cache/create-with-cache.ts
@@ -14,8 +14,8 @@ type CreateWithCacheOptions = {
   cache: Cache;
   /** The `waitUntil` function is used to keep the current request/response lifecycle alive even after a response has been sent. It should be provided by your platform. */
   waitUntil: WaitUntil;
-  /** The `request` object is used to access certain headers for debugging */
-  request?: CrossRuntimeRequest;
+  /** The `request` object is used by the Subrequest profiler, and to access certain headers for debugging */
+  request: CrossRuntimeRequest;
 };
 
 type WithCacheRunOptions<T> = {