Skip to content

Adds option value decoder utility functions #5868

Adds option value decoder utility functions

Adds option value decoder utility functions #5868

Triggered via pull request October 2, 2024 16:51
Status Failure
Total duration 1m 9s
Artifacts

ci.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

19 errors and 3 warnings
⬣ Prettier
Process completed with exit code 1.
⬣ Unit tests
'encodedOptionValues' is possibly 'null' or 'undefined'.
⬣ Unit tests
Argument of type 'EncodedOptionValues' is not assignable to parameter of type 'string'.
⬣ Unit tests
@shopify/hydrogen-react#build: command (/home/runner/work/hydrogen/hydrogen/packages/hydrogen-react) /opt/hostedtoolcache/node/20.17.0/x64/bin/npm run build exited (1)
⬣ Unit tests
Process completed with exit code 1.
Typescript
'encodedOptionValues' is possibly 'null' or 'undefined'.
Typescript
Argument of type 'EncodedOptionValues' is not assignable to parameter of type 'string'.
Typescript
@shopify/hydrogen-react#build: command (/home/runner/work/hydrogen/hydrogen/packages/hydrogen-react) /opt/hostedtoolcache/node/20.17.0/x64/bin/npm run build exited (1)
Typescript
Process completed with exit code 1.
⬣ ESLint: packages/hydrogen-react/src/index.ts#L1
Run autofix to sort these exports!
⬣ ESLint: packages/hydrogen-react/src/optionValueDecoder.test.ts#L6
Missing file extension "ts" for "./optionValueDecoder"
⬣ ESLint: packages/hydrogen-react/src/optionValueDecoder.ts#L12
Replace `·Product·}·from·"./storefront-api-types"` with `Product}·from·'./storefront-api-types'`
⬣ ESLint: packages/hydrogen-react/src/optionValueDecoder.ts#L12
Missing file extension for "./storefront-api-types"
⬣ ESLint: packages/hydrogen-react/src/optionValueDecoder.ts#L34
Missing return type on function
⬣ ESLint: packages/hydrogen-react/src/optionValueDecoder.ts#L64
Missing return type on function
⬣ ESLint: packages/hydrogen-react/src/optionValueDecoder.ts#L101
Replace `·Product['encodedVariantAvailability']` with `⏎··|·Product['encodedVariantAvailability']⏎·`
⬣ ESLint: packages/hydrogen-react/src/optionValueDecoder.ts#L106
tsdoc-param-tag-missing-hyphen: The @param block should be followed by a parameter name and then a hyphen
⬣ ESLint: packages/hydrogen-react/src/optionValueDecoder.ts#L109
Replace `encodedOptionValues:·EncodedOptionValues` with `⏎··encodedOptionValues:·EncodedOptionValues,⏎`
⬣ ESLint: packages/hydrogen-react/src/optionValueDecoder.ts#L117
Missing return type on function
⬣ ESLint: packages/hydrogen-react/src/optionValueDecoder.test.ts#L222
'input' is never reassigned. Use 'const' instead
⬣ ESLint: packages/hydrogen-react/src/optionValueDecoder.ts#L146
'options' is never reassigned. Use 'const' instead
⬣ ESLint: packages/hydrogen-react/src/optionValueDecoder.ts#L147
'currentOptionValue' is never reassigned. Use 'const' instead