Deprecate Oxygen.env in favor of Hydrogen.env #2150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blittle
commented
Sep 16, 2022
| @@ -4,10 +4,7 @@ title: Environment variables | |||
| description: Learn how to store sensitive information in your Hydrogen project. | |||
| --- | |||
|
|
|||
| Environment variables, also known as secrets, allow you to load different values in your app depending on the running environment. This guide describes how to store environment variables in your Hydrogen project. | |||
There was a problem hiding this comment.
Still thinking if we should provide Hydrogen.env in the browser with all the public variables... other than that, I think this is clear since now we don't have a distinction between public and private variables anymore.
cartogram
reviewed
Sep 19, 2022
cartogram
approved these changes
Sep 19, 2022
4 tasks
frandiox
approved these changes
Sep 20, 2022
There was a problem hiding this comment.
I think it looks good, thanks! I was worried about the behavior around PUBLIC_ but I see it was already changed in Shopify/hydrogen@7f97229 👍
rennyG
approved these changes
Sep 21, 2022
|
@blittle make sure you tophat this on .dev before shipping |
Co-authored-by: Ren Chaturvedi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Oxygen.envis now deprecated in favor ofHydrogen.env. Access environment variables within your server components onHydrogen.env. We hope this will make more sense when deploying to non-Oxygen environments.Additional context
Part of Shopify/hydrogen#1879
Before submitting the PR, please make sure you do the following:
fixes #123)yarn changeset addif this PR cause a version bump based on Keep a Changelog and adheres to Semantic Versioning