Skip to content

Fix compatibility with MySQL 8.x. #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix compatibility with MySQL 8.x. #397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion binlog_streamer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,7 +499,16 @@ func idExistsOnServer(id uint32, db *sql.DB) (bool, error) {
}

func idsOnServer(db *sql.DB) ([]uint32, error) {
rows, err := db.Query("SHOW SLAVE HOSTS")
// SHOW SLAVE HOSTS is deprecated as of MySQL 8.0.22, so fallback to a compatible query on newer servers.
// See https://dev.mysql.com/doc/refman/8.0/en/show-slave-hosts.html for details.
var rows *sqlorig.Rows
var err error
for _, q := range []string{"SHOW SLAVE HOSTS", "SHOW REPLICAS"} {
rows, err = db.Query(q)
if err == nil {
break
}
}
if err != nil {
return nil, fmt.Errorf("could not get slave hosts: %s", err)
}
Expand Down
12 changes: 11 additions & 1 deletion utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,10 +189,20 @@ func (c *StmtCache) getStmt(query string) (*sqlorig.Stmt, bool) {
}

func ShowMasterStatusBinlogPosition(db *sql.DB) (mysql.Position, error) {
rows, err := db.Query("SHOW MASTER STATUS")
// SHOW MASTER STATUS is deprecated as of MySQL 8.0.22, so fallback to a compatible query on newer servers.
// See https://dev.mysql.com/doc/refman/8.4/en/show-master-status.html for details.
var rows *sqlorig.Rows
var err error
for _, q := range []string{"SHOW MASTER STATUS", "SHOW BINARY LOG STATUS"} {
rows, err = db.Query(q)
if err == nil {
break
}
}
if err != nil {
return NewMysqlPosition("", 0, err)
}

defer rows.Close()
var file string
var position uint32
Expand Down
Loading