Skip to content

[Performance] Optimize sanitizedHeadersOutput header sanitization - #8338

Draft
gonzaloriestra wants to merge 1 commit into
mainfrom
performance-optimize-header-sanitization-2168919330683522285
Draft

[Performance] Optimize sanitizedHeadersOutput header sanitization#8338
gonzaloriestra wants to merge 1 commit into
mainfrom
performance-optimize-header-sanitization-2168919330683522285

Conversation

@gonzaloriestra

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

sanitizedHeadersOutput is called frequently when verbose logging or unit testing HTTP and GraphQL API requests/responses. Previously, it performed multiple object allocations and redundant iterations:

  1. Called header.toLowerCase() for every keyword in SENSITIVE_HEADERS inside a .find() callback on each header.
  2. Built an intermediate sanitized object using forEach.
  3. Extracted keys from sanitized with Object.keys() a second time to map into output strings.

WHAT is this pull request doing?

Refactors sanitizedHeadersOutput to use single-pass Object.entries(headers) filtering:

  • Lowercases each header name once per entry and caches it locally.
  • Short-circuits keyword checking using !SENSITIVE_HEADERS.some(...).
  • Directly maps filtered key-value pairs into formatted strings without intermediate object allocations or duplicate Object.keys() lookups.

How to test your changes?

Run any CLI command with --verbose flag (e.g. shopify app info --verbose) or execute API-related tests.

Post-release steps

None.

Measuring impact

Status File
OK packages/cli-kit/src/private/node/api/headers.ts

Checklist

  • I have read the Contributing Guidelines.
  • I have read the CLI Reference Standard for UX compliance.
  • I have included test coverage for new functionality or bug fixes.
  • I have updated the documentation where necessary.
  • I have tested my changes locally.
  • I have verified that all CI checks pass.

PR created automatically by Jules for task 2168919330683522285 started by @gonzaloriestra

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Aug 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant