[Tests] Remove filesystem mocks in dev-session-process.test.ts#7741
[Tests] Remove filesystem mocks in dev-session-process.test.ts#7741gonzaloriestra wants to merge 1 commit into
Conversation
Refactored `packages/app/src/cli/services/dev/processes/dev-session/dev-session-process.test.ts` to remove global filesystem mocking. Used `inTemporaryDirectory` to provide isolated real filesystem environments for each test. Replaced `flushPromises` with `vi.waitFor` to improve test reliability and avoid race conditions. Eliminated shared state by moving setup logic into individual test blocks via a `setup` helper.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
github-actions
Bot
added
the
no-changelog
1 participant
This PR refactors the unit tests for the dev session process to follow the project's testing guidelines by using a real filesystem instead of mocks.
Key Changes:
vi.mock('@shopify/cli-kit/node/fs').inTemporaryDirectoryto ensure isolation and clean up after execution.flushPromises()calls withvi.waitFor()to correctly synchronize with asynchronous status changes in theDevSession.beforeEach/afterEachshared state, moving it into a dedicatedsetuphelper called within each test block.How to test your changes?
CI
PR created automatically by Jules for task 3550839542173712765 started by @gonzaloriestra