Remove @apidevtools/json-schema-ref-parser from cli-kit (inline internal $ref resolver)#7724
Draft
amcaplan wants to merge 2 commits into
Draft
Remove @apidevtools/json-schema-ref-parser from cli-kit (inline internal $ref resolver)#7724amcaplan wants to merge 2 commits into
amcaplan wants to merge 2 commits into
Conversation
…nal $ref resolver Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
@apidevtools/json-schema-ref-parserdependency from@shopify/cli-kitpackage.jsonsrc/public/node/json-schema.tspnpm-lock.yamlto reflect dependency removalWhy
Reduce Dependabot churn: This dependency generated 13 bumps in 24 months from the dependency-removal initiative. Removing it eliminates unnecessary maintenance overhead while preserving functionality.
Replacement Details
Implemented a custom internal-only
$refresolver with cycle safety:#/...JSON pointers): Fully dereferenced inline with memoization to handle cycles$refproperties to maintain priorexternal: falsebehaviorValidation Results
All targeted validations pass:
pnpm --filter @shopify/cli-kit type-checkpnpm --filter @shopify/cli-kit lintpnpm --filter @shopify/cli-kit exec vitest run src/public/node/json-schema.test.ts— 16 passed🤖 Automated dependency-removal initiative — AI-generated draft, needs human review.