PROTO: Add --json to store commands#7186
Draft
dmerand wants to merge 1 commit intodlm-store-auth-logoutfrom
Draft
PROTO: Add --json to store commands#7186dmerand wants to merge 1 commit intodlm-store-auth-logoutfrom
dmerand wants to merge 1 commit intodlm-store-auth-logoutfrom
Conversation
This was referenced Apr 3, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What
Add explicit
--jsonsupport across theshopify store *command surface in this stack:shopify store authshopify store auth infoshopify store auth logoutshopify store executeThis also pushes the store-command internals toward an object-first shape, so services produce structured results and text rendering is derived from those results.
Why
These commands are intended to be agent-first surfaces, but their JSON behavior was inconsistent:
store authwas text-onlystore auth logoutwas text-onlystore executeprinted JSON-ish results but did not expose an explicit--jsoncontractThis change makes the machine-readable contract explicit while keeping the human output intact.
How
--jsontostore auth,store auth logout, andstore executestore auth infoon the same structured auth-state model asstore authpackages/cli/src/cli/services/store/auth-state.tsstore authso auth succeeds with a structured result and the presenter decides whether to render text or JSONstore executeexecution separate from final output, so the command writes/renders the returned result instead of mixing fetch and presentation in one servicegetStoreAuthInfo(...)so the service seam is defensive even outside command parsingTesting
Manual checks:
Things to verify:
store auth --jsonprints the final auth object to stdout without interleaving browser/progress textstore auth info --jsonandstore auth logout --jsonreturn structured objectsstore execute --jsonreturns only the GraphQL resultstore execute --output-file ... --jsonwrites the result file without printing the human success bannerConsidered
store executeas implicitly JSON-like without an explicit flagstore executeexecution and final output coupled in one servicePost-release steps
None.
Measuring impact
Checklist