Skip to content

Stop reporting user/environment errors as unexpected bugs #7168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lucyxiang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Stop reporting user/environment errors as unexpected bugs #7168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/cli-kit/src/public/node/error.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,4 +74,12 @@ describe('shouldReportErrorAsUnexpected helper', () => {
test('returns false for user-aborted requests', () => {
expect(shouldReportErrorAsUnexpected(new Error('The user aborted a request.'))).toBe(false)
})

test('returns false for EPIPE errors', () => {
expect(shouldReportErrorAsUnexpected(new Error('write EPIPE'))).toBe(false)
})

test('returns false for unsupported platform errors', () => {
expect(shouldReportErrorAsUnexpected(new Error('Unsupported platform: win32 arm64 LE'))).toBe(false)
})
})
2 changes: 2 additions & 0 deletions packages/cli-kit/src/public/node/error.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,8 @@ function errorMessageImpliesEnvironmentIssue(message: string): boolean {
'spawn EPERM',
'socket hang up',
'The user aborted a request.',
'write EPIPE',
'Unsupported platform',
]
const anyMatches = environmentIssueMessages.some((issueMessage) => message.includes(issueMessage))
return anyMatches
Expand Down
Loading