Faster startup (2/4): Fire-and-forget hooks + process.exit(0)#7052
Draft
gonzaloriestra wants to merge 1 commit intofaster-startupfrom
Draft
Faster startup (2/4): Fire-and-forget hooks + process.exit(0)#7052gonzaloriestra wants to merge 1 commit intofaster-startupfrom
gonzaloriestra wants to merge 1 commit intofaster-startupfrom
Conversation
3 tasks
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Mar 19, 2026
Closed
41b8681 to
82aafb4
Compare
b573cb7 to
e520d26
Compare
82aafb4 to
97a25a5
Compare
e520d26 to
d67ea57
Compare
d5aae16 to
bc7405e
Compare
2cc5f58 to
72fb003
Compare
Contributor
Coverage report
Test suite run success4000 tests passing in 1531 suites. Report generated by 🧪jest coverage report action from 4bad0ca |
16804e8 to
0b7096a
Compare
72fb003 to
5aeb8af
Compare
da82414 to
6d7630b
Compare
5aeb8af to
34fddbf
Compare
Run the command first with exclusive CPU time, then fire prerun/postrun hooks as fire-and-forget after command completes. Call process.exit(0) in bootstrap to avoid blocking on pending analytics/version-check network requests. Startup time: 570ms → 250ms (-56%)
6d7630b to
f3f181b
Compare
34fddbf to
4bad0ca
Compare
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationspackages/cli-kit/dist/public/node/custom-oclif-loader.d.tsimport { Command, Config } from '@oclif/core';
import { Options } from '@oclif/core/interfaces';
/**
* Optional lazy command loader function.
* If set, ShopifyConfig will use it to load individual commands on demand
* instead of importing the entire COMMANDS module (which triggers loading all packages).
*/
export type LazyCommandLoader = (id: string) => Promise<typeof Command | undefined>;
export declare class ShopifyConfig extends Config {
private lazyCommandLoader?;
constructor(options: Options);
/**
* Set a lazy command loader that will be used to load individual command classes on demand,
* bypassing the default oclif behavior of importing the entire COMMANDS module.
*
* @param loader - The lazy command loader function.
*/
setLazyCommandLoader(loader: LazyCommandLoader): void;
/**
* Override runCommand to use lazy loading when available.
* Instead of calling cmd.load() which triggers loading ALL commands via index.js,
* we directly import only the needed command module.
*
* @param id - The command ID to run.
* @param argv - The arguments to pass to the command.
* @param cachedCommand - An optional cached command loadable.
* @returns The command result.
*/
runCommand<T = unknown>(id: string, argv?: string[], cachedCommand?: Command.Loadable | null): Promise<T>;
customPriority(commands: Command.Loadable[]): Command.Loadable | undefined;
}
Existing type declarationspackages/cli-kit/dist/public/node/cli-launcher.d.ts@@ -1,6 +1,8 @@
+import type { LazyCommandLoader } from './custom-oclif-loader.js';
interface Options {
moduleURL: string;
argv?: string[];
+ lazyCommandLoader?: LazyCommandLoader;
}
/**
* Launches the CLI.
packages/cli-kit/dist/public/node/cli.d.ts@@ -1,3 +1,4 @@
+import type { LazyCommandLoader } from './custom-oclif-loader.js';
/**
* IMPORTANT NOTE: Imports in this module are dynamic to ensure that "setupEnvironmentVariables" can dynamically
* set the DEBUG environment variable before the 'debug' package sets up its configuration when modules
@@ -7,6 +8,8 @@ interface RunCLIOptions {
/** The value of import.meta.url of the CLI executable module */
moduleURL: string;
development: boolean;
+ /** Optional lazy command loader for on-demand command loading */
+ lazyCommandLoader?: LazyCommandLoader;
}
/**
* A function that abstracts away setting up the environment and running
@@ -17,6 +20,7 @@ export declare function runCLI(options: RunCLIOptions & {
runInCreateMode?: boolean;
}, launchCLI?: (options: {
moduleURL: string;
+ lazyCommandLoader?: LazyCommandLoader;
}) => Promise<void>, argv?: string[], env?: NodeJS.ProcessEnv, versions?: NodeJS.ProcessVersions): Promise<void>;
/**
* A function for create-x CLIs that automatically runs the "init" command.
@@ -38,5 +42,5 @@ export declare const jsonFlag: {
/**
* Clear the CLI cache, used to store some API responses and handle notifications status
*/
-export declare function clearCache(): void;
+export declare function clearCache(): Promise<void>;
export {};
\ No newline at end of file
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

WHY are these changes introduced?
The CLI requires too much time to start working, it feels slow
WHAT is this pull request doing?
Runs the command first with exclusive CPU time, then fires prerun/postrun hooks as fire-and-forget after command completes. Calls
process.exit(0)in bootstrap to avoid blocking on pending analytics/version-check network requests.runCommand: after the command finishes, prerun + postrun hooks run asynchronously without blocking the userprocess.exit(0)in bootstrap: forces exit after command completes so pending network I/O (analytics, upgrade checks) doesn't delay the prompt returningStartup time: 570ms → 250ms (-56%)
How to test your changes?
shopify version/shopify helpreturn correct output fastershopify app devstill reports analytics (fire-and-forget, best-effort)Measuring impact
Checklist
Made with Cursor