Skip to content

Fix local store domain #6735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
gonzaloriestra wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix local store domain #6735

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/cli-kit/src/public/node/context/fqdn.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,5 +139,8 @@ export function normalizeStoreFqdn(store: string): string {
}
const containDomain = (storeFqdn: string) =>
storeFqdn.endsWith('.myshopify.com') || storeFqdn.endsWith('shopify.io') || storeFqdn.endsWith('.shop.dev')
return containDomain(storeFqdn) ? storeFqdn : addDomain(storeFqdn)
const normalizedFqdn = containDomain(storeFqdn) ? storeFqdn : addDomain(storeFqdn)
// Use dev-api domain for OAuth redirects in local environment
// See: https://github.com/Shopify/dev_server?tab=readme-ov-file#shop-redirects
return normalizedFqdn.replace('.my.shop.dev', '.dev-api.shop.dev')
}
Loading