Skip to content

Improve bulk operation polling with faster initial checks and hide zero counts #6695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickwesselman merged 2 commits into from
Dec 11, 2025
Merged

Improve bulk operation polling with faster initial checks and hide zero counts #6695

nickwesselman merged 2 commits into from
Dec 11, 2025

Conversation

@nickwesselman
Copy link
Contributor

@nickwesselman nickwesselman commented Dec 8, 2025 •
edited
Loading

WHY are these changes introduced?

Improve the user experience when monitoring bulk operations by providing more responsive status updates and clearer progress information.

WHAT is this pull request doing?

  1. Enhances the bulk operation polling mechanism:

    • Uses a faster 1-second polling interval for the first 10 polls, then switches to 5 seconds
    • This provides more responsive feedback during the initial stages of a bulk operation

  2. Improves status formatting:

    • Hides the object count in the status message when the count is 0
    • Prevents showing "0 objects read/written" which could be confusing to users

  3. Adds comprehensive tests:

    • Verifies the polling interval behavior
    • Ensures proper formatting when object count is 0

How to test your changes?

  1. Run a bulk operation using the CLI
  2. Observe that status updates appear more frequently at the beginning
  3. Verify that when a bulk operation is in the RUNNING state with 0 objects, it doesn't display the object count

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@nickwesselman nickwesselman mentioned this pull request Dec 8, 2025
Merged
3 tasks
@nickwesselman nickwesselman changed the title poll more frequently the first 10 times Improve bulk operation polling with faster initial checks and hide zero counts Dec 8, 2025
This was referenced Dec 8, 2025
Merged
Merged
@nickwesselman Graphite App
Copy link
Contributor Author

nickwesselman commented Dec 8, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nickwesselman nickwesselman mentioned this pull request Dec 8, 2025
Merged
3 tasks
@nickwesselman nickwesselman marked this pull request as ready for review December 8, 2025 02:35
@nickwesselman nickwesselman requested a review from a team as a code owner December 8, 2025 02:35
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

@nickwesselman Graphite App
Copy link
Contributor Author

nickwesselman commented Dec 8, 2025

Part of https://github.com/shop/issues-api-foundations/issues/1149

@nickwesselman Graphite App
Copy link
Contributor Author

nickwesselman commented Dec 8, 2025

/snapit

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

🫰✨ Thanks @nickwesselman! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/[email protected]

Caution

After installing, validate the version by running just shopify in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟡 Statements
79.21% (+0.01% 🔼)
 13921/17574
🟡 Branches
73.21% (+0.01% 🔼)
 6803/9293
🟡 Functions 79.35% 3565/4493
🟡 Lines
79.57% (+0% 🔼)
 13151/16528

Test suite run success

3492 tests passing in 1408 suites.

Report generated by 🧪jest coverage report action from 9d4706e

jordanverasamy
jordanverasamy approved these changes Dec 8, 2025
View reviewed changes
Copy link
Contributor

@jordanverasamy jordanverasamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice change! kept it simple and clean, love it 👌🏾

@nickwesselman nickwesselman force-pushed the poll_bulk_operations_faster branch from 0ffa7ec to a694179 Compare December 9, 2025 13:32
@nickwesselman nickwesselman mentioned this pull request Dec 9, 2025
Merged
5 tasks
@nickwesselman nickwesselman force-pushed the poll_bulk_operations_faster branch from a694179 to d894b0c Compare December 9, 2025 20:20
@nickwesselman nickwesselman force-pushed the use_integer_for_status_id branch from 6b4b9cb to e72bf3d Compare December 9, 2025 20:20
ericlee878
ericlee878 approved these changes Dec 9, 2025
View reviewed changes
Copy link
Contributor

@ericlee878 ericlee878 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool idea!

@nickwesselman nickwesselman force-pushed the use_integer_for_status_id branch from e72bf3d to e7d4f1f Compare December 10, 2025 14:13
@nickwesselman nickwesselman requested a review from a team as a code owner December 10, 2025 14:13
@nickwesselman nickwesselman force-pushed the poll_bulk_operations_faster branch from d894b0c to 544183d Compare December 10, 2025 14:14
@nickwesselman nickwesselman force-pushed the use_integer_for_status_id branch from e7d4f1f to 8dffee6 Compare December 10, 2025 16:10
@nickwesselman nickwesselman force-pushed the poll_bulk_operations_faster branch from 544183d to 9d4706e Compare December 10, 2025 16:10
@nickwesselman nickwesselman mentioned this pull request Dec 10, 2025
Draft
3 tasks
gonzaloriestra
gonzaloriestra approved these changes Dec 11, 2025
View reviewed changes
Copy link
Contributor

@gonzaloriestra gonzaloriestra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Base automatically changed from use_integer_for_status_id to main December 11, 2025 14:15
@nickwesselman nickwesselman added this pull request to the merge queue Dec 11, 2025
Merged via the queue into main with commit 426706b Dec 11, 2025
25 of 45 checks passed
@nickwesselman nickwesselman deleted the poll_bulk_operations_faster branch December 11, 2025 14:24
@gonzaloriestra gonzaloriestra mentioned this pull request Dec 12, 2025
Merged
@nickwesselman nickwesselman mentioned this pull request Dec 12, 2025
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jordanverasamy jordanverasamy jordanverasamy approved these changes

@gonzaloriestra gonzaloriestra gonzaloriestra approved these changes

@ericlee878 ericlee878 ericlee878 approved these changes

Assignees

No one assigned

Labels

#gsd:47715

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nickwesselman @jordanverasamy @gonzaloriestra @ericlee878