[Swift] Stop emitting ec_color_scheme query param#96
Open
Juanita-Dash wants to merge 1 commit into
Open
Conversation
toneymathews
approved these changes
May 13, 2026
toneymathews
left a comment
toneymathews
left a comment
There was a problem hiding this comment.
leaving one question, lgtm otherwise
| var onFailAction: ((CheckoutError) -> Void)? | ||
|
|
||
| public init(checkout url: URL) { | ||
| checkoutURL = CheckoutProtocol.url(for: url, colorScheme: ShopifyCheckoutKit.configuration.colorScheme.rawValue) |
There was a problem hiding this comment.
Do we need to remove it on the configuration object itself?
Juanita-Dash
force-pushed
the
swift/remove-ec-color-scheme
branch
from
bf9bf8a to
782815b
Compare
markmur
reviewed
May 14, 2026
Comment on lines
+42
to
+46
| @Test func doesNotEmitEcColorScheme() { | ||
| let result = CheckoutProtocol.url(for: baseURL) | ||
| let names = queryItems(result).map(\.name) | ||
| #expect(names.contains("ec_color_scheme") == false) | ||
| } |
Contributor
There was a problem hiding this comment.
No need for this test since the app code doesn't actually include the param - even conditionally
Part of shop/issues-checkout-kit#906. The Checkout Kits will no longer thread color scheme through ECP. This PR strips ec_color_scheme emission from the Swift kit: - CheckoutProtocol.url(for:): drop the colorScheme parameter and the ec_color_scheme queryItem; ec_version still emitted - CheckoutViewController.init and ShopifyCheckoutKit.preload/present: drop the colorScheme argument at the 4 call sites CheckoutProtocol.url(for:colorScheme:) is public but PR #65 has not yet been released (no 3.8.0 tag), so removing the parameter outright is safe. Android equivalent landed in #95. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Juanita-Dash
force-pushed
the
swift/remove-ec-color-scheme
branch
from
782815b to
4778478
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/shop/issues-checkout-kit/issues/906.
This recent PR appended ec_color_scheme to the checkout URL but a decision has been made to no longer have this query param. This PR strips ec_color_scheme emission from the Swift kit:
ec_color_scheme queryItem; ec_version still emitted
drop the colorScheme argument at the 4 call sites
Android equivalent landed in #95.
🤖 Generated with Claude Code