Add @shopify/checkout-kit web platform scaffolding and CI#93
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Web — Coverage Report
|
React Native — Coverage Report
|
toneymathews
left a comment
toneymathews
left a comment
There was a problem hiding this comment.
We could add updates on this component to the root level CLAUDE.md and AGENTS.md, but that's minor, can be done later as well.
LGTM
|
|
||
| "strict": true, | ||
| "noFallthroughCasesInSwitch": true, | ||
| "noImplicitOverride": true, |
There was a problem hiding this comment.
nit - This does mean we'd have to prepend override in a bunch of places in the component code in the upstream PR.
- ShopifyCheckout extends ShopifyElement (which extends HTMLElement)
addEventListenerwill now need to be declared asoverride addEventListener.
This shouldn't matter, just noting a change that'll come up in the web component code
There was a problem hiding this comment.
I removed that ShopifyElement inheritance in a recent update. BUt yeah might be worth considering if this tsconfig is what we want in general this is a sane default i snagged but once we port in the component we can see and tweak I would say.
There was a problem hiding this comment.
Sounds good, i've added the web component on top now - #83. Cleaning it up now
toneymathews
force-pushed
the
checkout-kit-web
branch
from
75d55f6 to
361a362
Compare
Introduces the fourth platform target — a vanilla JS / Web Components build of Checkout Kit. This commit is scaffolding only: src/index.ts exports a single VERSION string as a placeholder. The component implementation will land in follow-up PRs. platforms/web/ * Vite library build emitting a single ESM bundle plus .d.ts * Vitest with happy-dom, v8 coverage, and json-summary output * oxlint + oxfmt for linting/formatting * publint via `pnpm verify` to catch package.json regressions * custom-elements-manifest generation on build for IDE tooling * scripts/check_license_headers.rb mirrors the Android check .github/workflows/ * web.yml — lint, test (with PR coverage comment), build, publint verify, and pack-and-inspect * ci.yml — adds web and web-license-headers jobs behind the paths-filter .github/dependabot.yml * Adds an npm ecosystem entry for /platforms/web
westeezy
force-pushed
the
checkout-kit-web
branch
from
361a362 to
ad50693
Compare
2 participants
What changes are you making?
Introduces the fourth platform target — a vanilla JS / Web Components
build of Checkout Kit.
This commit is scaffolding only: src/index.ts exports a single VERSION
string as a placeholder. The component implementation will land in
follow-up PRs.
platforms/web/
pnpm verifyto catch package.json regressions.github/workflows/
verify, and pack-and-inspect
paths-filter
.github/dependabot.yml
How to test
Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
platforms/swift/ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/CHANGELOG.mdplatforms/swift/README.md(major version only)Releasing a new Android version?
versionNameinplatforms/android/lib/build.gradleplatforms/android/CHANGELOG.mdplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.