Remove web pixel events#81
Open
tiagocandido wants to merge 1 commit into
Open
Conversation
f48c6bf to
99b81da
Compare
99b81da to
34f8647
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
Removes Web Pixel event support across all platforms. The new UCP-based bridge does not emit pixel events, so the public surface that exposed them is being dropped to match the current protocol version.
Android (library + sample)
onWebPixelEventfromCheckoutEventProcessor/DefaultCheckoutEventProcessorand theWEB_PIXELSbranch inCheckoutBridge.com.shopify.checkoutkit.pixeleventspackage (28@Serializabletypes + decoder).MoneyV2tocom.shopify.checkoutkit.lifecycleevents(still referenced byCompletedEvent).lib/api/lib.api.PixelEventDetailsscreen, and thepixelEventJsoncolumn onLogLine. Bumps Room schema v2 → v3 withfallbackToDestructiveMigration.Swift (sample + README only)
WebPixelEventsView,WebPixelsLogReader, thewebPixelsLoggerwiring inAppConfiguration, and the Settings nav row.platforms/swift/README.md.React Native (library + sample)
'pixel'event listener,onWebPixelEventprop onAcceleratedCheckoutButtons,parseCustomPixelData, theWebPixelEventcodegen prop, and pixel types fromindex.d.ts.CustomCheckoutEventProcessor.java's override,checkoutDidEmitWebPixelEventinShopifyCheckoutKit.swift, the serializer inShopifyCheckoutKit+EventSerialization.swift,onWebPixelEventwiring inAcceleratedCheckoutButtons.swift, and the correspondingRCT_EXPORT_VIEW_PROPERTYinShopifyCheckoutKit.mm.pixellistener registration and handler.How to test
Android
All green locally. Manually: open the sample, run a checkout, confirm the logs screen no longer shows a pixel row and that the first launch after upgrade does not crash on Room migration.
Swift
All green locally. Manually: open the MobileBuyIntegration sample, confirm Settings no longer shows the "Web pixel events" row and the app launches without referencing the deleted view.
React Native
Manually: drive a checkout in the sample and confirm no
'pixel'listener registration remains;tscwill surface any consumer code still referencing the removed surface.Before you merge
Important
platforms/swift/README.mdandplatforms/android/README.md, plusplatforms/react-native/README.md)Releasing a new Swift version?
Not released as part of this PR — Swift changes are sample + docs only.
platforms/swift/ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/CHANGELOG.mdplatforms/swift/README.md(major version only)Releasing a new Android version?
Release bump to be handled in a follow-up — this is a major version (breaking API removal).
versionNameinplatforms/android/lib/build.gradleplatforms/android/CHANGELOG.mdplatforms/android/README.md