drop deprecated android.nonFinalResIds opt-out#80
Open
kiftio wants to merge 2 commits into
Open
Conversation
AGP 9 deprecates the android.nonFinalResIds option and will remove it in AGP 10; the new default is true (non-final R-class constants). Library is a Kotlin-only consumer with no Java switch statements on R.*, so flipping to the default is a no-op for both lib/ and the sample.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
android.nonFinalResIds=falsefrom bothgradle.propertiesfiles. AGP 9 deprecates this option and will remove it in AGP 10. The new default istrue(non-final R-class constants), which is fine for this codebase.Changes
gradle.properties: removeandroid.nonFinalResIds=false.samples/MobileBuyIntegration/gradle.properties: removeandroid.nonFinalResIds=false.Why now
builtInKotlin=falseandnewDsl=falseopt-outs, which still need to stay until upstream catches up.Consumer impact
None.
non-finalonly breaks Javaswitch (R.*) { case ... }statements (Java requires compile-time constants as case labels).lib/src/main. The sample contains zero.javafiles.com.shopify.checkoutkit.R) is library-internal; third-party consumers don't reference our R values.Audit run before flipping: zero
switchstatements on R constants acrosslib/andsamples/.Test plan
./gradlew :lib:clean :lib:test :lib:detekt :lib:lintRelease :lib:apiCheck :lib:assembleRelease— green./gradlew assembleDebugfromsamples/MobileBuyIntegration/— greenWARNING: The option setting 'android.nonFinalResIds=false' is deprecatedno longer appears in build outputWhat changes are you making?
How to test
Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
platforms/swift/ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/CHANGELOG.mdplatforms/swift/README.md(major version only)Releasing a new Android version?
versionNameinplatforms/android/lib/build.gradleplatforms/android/CHANGELOG.mdplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.