Skip to content

[Android] Add window.open UCP delegation#107

Merged
tiagocandido merged 1 commit into
mainfrom
05-14-_android_add_window.open_ucp_delegation
May 15, 2026
Merged

[Android] Add window.open UCP delegation#107
tiagocandido merged 1 commit into
mainfrom
05-14-_android_add_window.open_ucp_delegation

Conversation

@tiagocandido
Copy link
Copy Markdown
Contributor

@tiagocandido tiagocandido commented May 14, 2026

What changes are you making?

Completes the window.open UCP delegation handshake on Android, bringing it to parity with Swift PR #82. The kit advertises window.open in the ec.ready response, handles ec.window.open_request internally via an ACTION_VIEW Intent, and narrows the native link-intercept to non-http schemes. The legacy consumer-facing link-click hooks are removed in favor of fully kit-internal handling.

Before you merge

Important

  • I've added tests to support my implementation
  • I have read and agree with the Contribution Guidelines
  • I have read and agree with the Code of Conduct
  • I've updated the relevant platform README (platforms/swift/README.md and/or platforms/android/README.md)

Releasing a new Swift version?
  • I have bumped the version in platforms/swift/ShopifyCheckoutKit.podspec
  • I have bumped the version in platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift
  • I have updated platforms/swift/CHANGELOG.md
  • I have updated the SwiftPM/CocoaPods version snippets in platforms/swift/README.md (major version only)
Releasing a new Android version?
  • I have bumped the versionName in platforms/android/lib/build.gradle
  • I have updated platforms/android/CHANGELOG.md
  • I have updated the Gradle/Maven version snippets in platforms/android/README.md

Tip

See the Contributing documentation for the full release process per platform.

Copy link
Copy Markdown
Contributor Author

tiagocandido commented May 14, 2026

Copy link
Copy Markdown
Contributor Author

@tiagocandido tiagocandido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open leads from Swift PR #82 mirrored here so they don't get lost during cross-platform parity work.

@tiagocandido tiagocandido force-pushed the 05-14-_android_add_window.open_ucp_delegation branch from 0a78dac to 7ce2cfb Compare May 14, 2026 10:46
@tiagocandido tiagocandido force-pushed the 05-14-_android_add_window.open_ucp_delegation branch 2 times, most recently from 5a6241f to 9e15892 Compare May 14, 2026 13:19
@tiagocandido tiagocandido marked this pull request as ready for review May 14, 2026 13:20
@tiagocandido tiagocandido requested a review from a team as a code owner May 14, 2026 13:20
@tiagocandido tiagocandido added the #gsd:50662 Rebase Checkout Kit on UCP label May 14, 2026 — with Graphite App
Comment thread platforms/android/lib/src/main/java/com/shopify/checkoutkit/CheckoutProtocol.kt Outdated
Comment thread platforms/android/lib/src/main/java/com/shopify/checkoutkit/CheckoutProtocol.kt Outdated
Comment thread platforms/android/lib/src/test/java/com/shopify/checkoutkit/Helpers.kt Outdated
@tiagocandido tiagocandido force-pushed the 05-14-_android_add_window.open_ucp_delegation branch from 9e15892 to 08f6c9d Compare May 14, 2026 16:19
@tiagocandido tiagocandido requested a review from kiftio May 14, 2026 16:22
@tiagocandido tiagocandido merged commit 843af89 into main May 15, 2026
17 checks passed
@tiagocandido tiagocandido deleted the 05-14-_android_add_window.open_ucp_delegation branch May 15, 2026 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#gsd:50662 Rebase Checkout Kit on UCP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants