Don't try to set SO_REUSEADDR on sockets of AF_UNIX (valkey-io#451)

Despite the fact that SO_REUSEADDR can be set on a Unix domain socket via setsockopt() without reporting an error, SO_REUSEADDR was actually created for ipv4/ipv6 and it's not supported for sockets of AF_UNIX. Therefore, setting this option on a Unix domain socket does nothing but costs one extra system call. Signed-off-by: Andy Pan <[email protected]>
Shivshankar-Reddy · May 7, 2024 · cde8ec1 · cde8ec1
1 parent ba9dd7b
commit cde8ec1
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/anet.c b/src/anet.c
@@ -616,7 +616,7 @@ int anetUnixServer(char *err, char *path, mode_t perm, int backlog)
     }
 
     int type = SOCK_STREAM;
-    int flags = ANET_SOCKET_CLOEXEC | ANET_SOCKET_NONBLOCK | ANET_SOCKET_REUSEADDR;
+    int flags = ANET_SOCKET_CLOEXEC | ANET_SOCKET_NONBLOCK;
     if ((s = anetCreateSocket(err,AF_LOCAL,type,0,flags)) == ANET_ERR)
         return ANET_ERR;