Skip to content

Commit

Permalink
Disable flaky empty shard slot migration tests (valkey-io#1027)
Browse files Browse the repository at this point in the history
Will continue my investigation offline

Signed-off-by: Ping Xie <[email protected]>
  • Loading branch information
PingXie authored Sep 13, 2024
1 parent f7c5b40 commit 3cc619f
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions tests/unit/cluster/slot-migration.tcl
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,7 @@ proc create_empty_shard {p r} {

# Temporarily disable empty shard migration tests while we
# work to reduce their flakiness. See https://github.com/valkey-io/valkey/issues/858.
if {0} {
start_cluster 3 5 {tags {external:skip cluster} overrides {cluster-allow-replica-migration no cluster-node-timeout 1000} } {

set node_timeout [lindex [R 0 CONFIG GET cluster-node-timeout] 1]
Expand Down Expand Up @@ -294,6 +295,7 @@ start_cluster 3 5 {tags {external:skip cluster} overrides {cluster-allow-replica
wait_for_slot_state 7 "\[609-<-$R0_id\]"
}
}
}

proc migrate_slot {from to slot} {
set from_id [R $from CLUSTER MYID]
Expand Down

0 comments on commit 3cc619f

Please sign in to comment.