Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for validation errors #168

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Add documentation for validation errors #168

merged 2 commits into from
Nov 15, 2024

Conversation

AndrewBenzSW
Copy link
Contributor

@AndrewBenzSW AndrewBenzSW commented Nov 15, 2024 •
edited
Loading

There was no documentation around the recently added ValidationError so this PR addresses that.

joshuaflanagan
joshuaflanagan approved these changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@joshuaflanagan joshuaflanagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Add a suggested blurb to make guidance more explicit.

@AndrewBenzSW @joshuaflanagan
Update error-handling/_validation-error.md
a1d3b2c 
Accept documentation suggestion

Co-authored-by: Joshua Flanagan <[email protected]>
@AndrewBenzSW AndrewBenzSW merged commit f8b1648 into main Nov 15, 2024
2 checks passed
@AndrewBenzSW AndrewBenzSW deleted the abenz/document-validation-error branch November 15, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuaflanagan joshuaflanagan joshuaflanagan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndrewBenzSW @joshuaflanagan