Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: native rendering datasource information. #158

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

LukaszParala
Copy link
Contributor

No description provided.

Copy link
Contributor

@PrzemyslawSpringer PrzemyslawSpringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cosmetics

@@ -14,6 +14,13 @@ or the bracket notation:
```code
$['shipment']['tracking_number']
```

For each document you need to select DataSource property. Select a 'package' if you want to print label for each package, and 'shipment' if you want only one label for whole shipment.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For each document you need to select DataSource property. Select a 'package' if you want to print label for each package, and 'shipment' if you want only one label for whole shipment.
For each document you need to select DataSource property value:
* **package** - prints a label for each package in the shipment;
* **shipment** - prints only one label for the whole shipment.

To consider, and check whether formats and looks nice. Bold values are consistent with listings on DesignerWindow page

@@ -83,7 +90,7 @@ $.shipment.metadata['account.number']

#### Current package reference

You can also reference to the current *Package* using prefix `@`
If you select 'package' as DataSources, you can also reference to the current *Package* using prefix `@`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you select 'package' as DataSources, you can also reference to the current *Package* using prefix `@`
If you select **package** as DataSource, you can also refer to the current *Package* using prefix `@`

At least 'DataSources' typo to be fixed

@LukaszParala LukaszParala merged commit dc1b4c7 into main Jan 24, 2024
3 checks passed
@LukaszParala LukaszParala deleted the lparala/add-data-source-for-document-designer branch January 24, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants