FILE_CONENT property proposal. #1737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ml86
force-pushed
the
markus/fileContent
branch
from
80ecd42
to
2ce2823
Compare
fabsx00
requested changes
Oct 17, 2023
|
We already have a CONTENT property which is used for CONFIG_FILE nodes. I did not want to reuse it to avoid confusion. As for the offsets: Yes, i can just name them OFFSET end OFFSET_END. |
Renamed FILE_CONTENT_OFFSET to OFFSET and FILE_CONTENT_OFFSET_END to OFFSET_END.
|
Ok, i now reuse the already existing CONTENT property. |
fabsx00
approved these changes
Oct 17, 2023
johannescoetzee
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.