Style Sign-Up and Log-In pages. #1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This styles the sign-up and log-in pages to mostly match their designs. There were no design mockups for mobile, so this includes a best-effort attempt at defining styles for mobile. As part of this change, this also moves the `Partners` component out of the `HomePage` directory and to the common components directory, since that component is now intended to be reused on these new pages. Also, this removes a bit of margin from the component's definition, since the sign-up and log-in pages shouldn't have that much margin, and it has been manually added back to the `HomePage` in the form of an ad hoc spacer div.
|
Thanks for reviewing this, @schroerbrian! |
|
Also, I realized that I forgot to style the authentication code modal, so I created a new ticket, #1359, for that. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1316 and #1317.
This styles the sign-up and log-in pages to mostly match their designs. There were no design mockups for mobile, so this includes a best-effort attempt at defining styles for mobile.
As part of this change, this also moves the
Partnerscomponent out of theHomePagedirectory and to the common components directory, since that component is now intended to be reused on these new pages. Also, this removes a bit of margin from the component's definition, since the sign-up and log-in pages shouldn't have that much margin, and it has been manually added back to theHomePagein the form of an ad hoc spacer div.Here are some screenshots of what this looks like:
Sign-up
Log-in
Very wide screen
Mobile screen