Repository navigation
ci: run ClientDisconnectTests again in the Release SwiftLM job - #116
Merged
Merged
Conversation
SwiftLM#256 (69bc71c) replaced Task.sleep(for:) in its tests. On Swift 6.2.4 in Release
that call aborts the XCTest process ('freed pointer was not the last allocation'); the
suite now passes there (7 tests, 464 in the whole bundle, checked locally).
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
--skip ClientDisconnectTestsfrom theswiftlmjob in.github/workflows/ci.yml;--disable-swift-testingstays.Why
ClientDisconnectTestsaborted the XCTest process in Release on Swift 6.2.4 (Xcode 26.3). Root cause:Task.sleep(for:)in the SwiftLM test bundle (not SwiftLM's cancellation code). SharpAI/SwiftLM#256, merged as69bc71c, switched the test sleeps toTask.sleep(nanoseconds:). The job checks out SwiftLMmain, so it already has that fix.Evidence
ClientDisconnectTests7 tests 0 failures, wholeSwiftLMTestsbundle 464 tests 0 failures (EXIT=0).CI SwiftLMjob must run the 7 tests and pass. Merge only if it is green; a CANCELLED check is not a pass.Not verified
Task.sleep(for:)calls inServer.swiftbehave on 6.2.4 outside tests (not changed).🤖 Generated with Claude Code