Repository navigation
fix: end DFlash generation on a stop token - #267
Merged
Merged
Conversation
The DFlash bridge handed a stop id to onStopToken, and when the handler answered .more it kept going, so the committed tokens after the stop id from the same DFlash block reached onToken and the client. A tool call written after the stop token was parsed too. A stop id now always ends the generation, as on the standard path (Evaluate.swift breaks out on any stop id). The existing finish block runs: onGenerationEnd, one .info with stopReason .stop, and the task is cancelled. Non-stop tokens are unchanged. Adds testStopTokenEndsGenerationAndDropsLaterTokens, which failed on origin/main with chunks ["t5 ", "t7 ", "t8 "]. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #265.
The DFlash bridge handed a stop id to
onStopToken. When the handler answered.more, the bridge kept going, so the committed tokens after the stop id, from the same DFlash block, reachedonTokenand the client. A tool call written after the stop token was parsed too.A stop id now always ends the generation, as on the standard path (
Evaluate.swiftbreaks out on any stop id). The existing finish block runs:onGenerationEnd, one.infowithstopReason .stop, and the task is cancelled. Non-stop tokens are unchanged.Verified
testStopTokenEndsGenerationAndDropsLaterTokens(new): failed onorigin/mainwith chunks["t5 ", "t7 ", "t8 "], passes with this change.swift test --filter DFlashStreamBridgeTestson this branch: 8 tests, 0 failures, EXIT=0.🤖 Generated with Claude Code