Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved dark mode colors #1246

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Improved dark mode colors #1246

wants to merge 6 commits into from

Conversation

nilsreichardt
Copy link
Member

Before After
Screenshot 2024-01-12 at 18 54 15 Screenshot 2024-01-12 at 18 52 05

@nilsreichardt
Copy link
Member Author

@Jonas-Sander WDYT?

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 12, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit d67c7dd):

https://sharezone-website-dev--pr1246-new-dark-mode-n90qv12c.web.app

(expires Sun, 21 Jan 2024 15:07:45 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 372b0431a96247f908d9a97d5d865de1c8b3b04e

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 12, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit d67c7dd):

https://sharezone-test--pr1246-new-dark-mode-x5buk7hn.web.app

(expires Sun, 21 Jan 2024 15:09:15 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@github-actions github-actions bot added feature: homework feature: notifications Push-Notifications and In-App-Notifications. feature: timetable / calendar Includes anything regarding lessons (timetable) and events (calendar). feature: information sheet Information sheets are posted to courses as a way to announce information. feature: attachments Attachments are files that can be added to homeworks or information sheets. feature: groups:courses Specific to only courses (instead of e.g. classes) feature: groups:classes Specific to only classes (instead of e.g. courses) feature: groups Groups umbrella term for courses and classes. testing user: teacher feature: sharezone plus Includes everything that is related to the Sharezone Plus subscription labels Jan 12, 2024
@nilsreichardt nilsreichardt added the build-app-preview A label that can be assigned to a PR to trigger a build of the app preview. label Jan 13, 2024
@Sharezone-Admin
Copy link
Member

Sharezone-Admin commented Jan 13, 2024 •
edited
Loading

⬇️ Builds generated by Codemagic for commit d67c7dd ⬇️

Note: Only Sharezone team members are able to install the iOS app.

iOS Android
iOS QR code
Download link		 Android QR code
Download link

(expires Sat, 17 Feb 2024 15:26:35 GMT)
Codemagic build: 65a93e24e6c4de3a7d1581f7; comment generated with Codemagic App Preview

@Jonas-Sander
Copy link
Collaborator

I'm okay with using cards and not just outlines but I think right now the contrast is too little.
I think the background color should stay relatively dark, right now everything just looks kinda grey and washed out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jonas-Sander Jonas-Sander Awaiting requested review from Jonas-Sander Jonas-Sander is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
build-app-preview A label that can be assigned to a PR to trigger a build of the app preview. feature: attachments Attachments are files that can be added to homeworks or information sheets. feature: groups:classes Specific to only classes (instead of e.g. courses) feature: groups:courses Specific to only courses (instead of e.g. classes) feature: groups Groups umbrella term for courses and classes. feature: homework feature: information sheet Information sheets are posted to courses as a way to announce information. feature: notifications Push-Notifications and In-App-Notifications. feature: sharezone plus Includes everything that is related to the Sharezone Plus subscription feature: timetable / calendar Includes anything regarding lessons (timetable) and events (calendar). testing ui: dark-mode ui / ux user: teacher
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nilsreichardt @Sharezone-Admin @Jonas-Sander