Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert lightTheme and darkTheme to methods #1234

Merged
merged 2 commits into from
Jan 6, 2024
Merged

Convert lightTheme and darkTheme to methods #1234

merged 2 commits into from
Jan 6, 2024

Conversation

nilsreichardt
Copy link
Member

This PR converts the variables lightTheme and darkTheme to the methods getLightTheme() and getDarkTheme(). The reason for this is that in golden tests outside of /app, the golden_toolkit package is unable to load our "Rubik" font (see eBay/flutter_glove_box#158). With this method, the golden tests can override the font family with a font like "Roboto".

@github-actions github-actions bot added feature: homework feature: notifications Push-Notifications and In-App-Notifications. legal Regarding Licenses, Policy updates, Warnings to users (that might cause trouble if not there) etc. feature: timetable / calendar Includes anything regarding lessons (timetable) and events (calendar). feature: information sheet Information sheets are posted to courses as a way to announce information. ui / ux feature: groups:courses Specific to only courses (instead of e.g. classes) feature: groups Groups umbrella term for courses and classes. feature: navigation Navigation inside the app (e.g. switching to a different screen). testing feature: onboarding The steps (setting username, courses, etc.) after creating a new account. ui: light-mode feature: authentification Logging in/out (anonymous, sign-in with X, etc.) and registration. user: teacher ui: dark-mode feature: sharezone plus Includes everything that is related to the Sharezone Plus subscription w: dashboard-page Page that shows a summary of all important things (homeworks, events, etc.). labels Jan 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2024

Visit the preview URL for this PR (updated for commit 7dada64):

https://sharezone-website-dev--pr1234-theme-methods-vhpg4kvj.web.app

(expires Tue, 09 Jan 2024 16:33:29 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 372b0431a96247f908d9a97d5d865de1c8b3b04e

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2024

Visit the preview URL for this PR (updated for commit 7dada64):

https://sharezone-test--pr1234-theme-methods-yaoii5cs.web.app

(expires Tue, 09 Jan 2024 16:34:44 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@nilsreichardt nilsreichardt added this pull request to the merge queue Jan 6, 2024
Merged via the queue into main with commit e22d4b6 Jan 6, 2024
27 checks passed
@nilsreichardt nilsreichardt deleted the theme-methods branch January 6, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jonas-Sander Jonas-Sander Jonas-Sander approved these changes

Assignees
No one assigned
Labels
feature: authentification Logging in/out (anonymous, sign-in with X, etc.) and registration. feature: groups:courses Specific to only courses (instead of e.g. classes) feature: groups Groups umbrella term for courses and classes. feature: homework feature: information sheet Information sheets are posted to courses as a way to announce information. feature: navigation Navigation inside the app (e.g. switching to a different screen). feature: notifications Push-Notifications and In-App-Notifications. feature: onboarding The steps (setting username, courses, etc.) after creating a new account. feature: sharezone plus Includes everything that is related to the Sharezone Plus subscription feature: timetable / calendar Includes anything regarding lessons (timetable) and events (calendar). legal Regarding Licenses, Policy updates, Warnings to users (that might cause trouble if not there) etc. testing ui: dark-mode ui: light-mode ui / ux user: teacher w: dashboard-page Page that shows a summary of all important things (homeworks, events, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nilsreichardt @Jonas-Sander