feat(Unified Controller): add unified controller driver #294
Conversation
ShadowApex
force-pushed
the
shadowapex/grand-unified-controller
branch
2 times, most recently
from
7efc1dd to
b47464d
Compare
ShadowApex
force-pushed
the
shadowapex/grand-unified-controller
branch
4 times, most recently
from
91d905b to
c25d78f
Compare
| Ok(vec![]) | ||
| } | ||
|
|
||
| fn handle_input_report( |
There was a problem hiding this comment.
I like this a lot. I think we can use a similar pattern in other drivers to simplify them.
| MouseButtonSide = 0x113, | ||
| MouseButtonExtra = 0x114, | ||
|
|
||
| /// Base button, usually on the bottom right, Steam Quick Access Button (...) |
There was a problem hiding this comment.
We should avoid calling this Base Button, those buttons are reserved for the physical base of a joystick. Only the openSD driver uses BTN_BASE for this, which is wrong.
| GamepadButtonNorth = 0x133, | ||
| /// West action, Sony Triangle ∆, XBox Y, Nintendo X | ||
| GamepadButtonWest = 0x134, | ||
| /// Select, Sony Select, Xbox Back, Nintendo -, Steam Deck ⧉ |
There was a problem hiding this comment.
Steam are following the xone symbols for this, xb360 and previous used start select, all modern xbox use menu/view
| /// Touch binary sensor for right stick | ||
| GamepadButtonRightStickTouch = 0x30e, | ||
|
|
||
| /// Dedicated button to open an on-screen keyboard |
There was a problem hiding this comment.
the following 3 events are out of numerical order
|
Took a quick look, nothing major stands out. I'll run some tests and let you know how it goes. This is great. |
ShadowApex
force-pushed
the
shadowapex/grand-unified-controller
branch
from
c25d78f to
af6ad93
Compare
|
🎉 This PR is included in version 0.48.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This change adds the Unified Controller as defined by the Unified Controller Input Spec. If used as a target device, it will create a virtual hidraw interface that will send input reports based on the source device capabilities.