fix(ci): build @erase2d/core
#33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@raulfelix what do you think? |
|
you can try latest: |
Tested and its working. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #31
As mentioned in the issue
@erase2d/coreis a dependency but it is not published to npm or updated to a public version. I decided to skip that and build core as part of the bundle for the fabric binding via rollup and make core a dev dependency.I am not sure this is the best way, maybe it is better to publish core, but for now it seems unnecessary because core doesn't really offer enough value on its own (only 2 very simple methods).
I have also removed minifying via the terser plugin.