This repository has been archived by the owner on Dec 16, 2024. It is now read-only.
fix: modal accessibility #633
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nerixyz
force-pushed
the
fix/accessibility
branch
from
0731d5a to
d477b3d
Compare
AnatoleAM
force-pushed
the
dev
branch
6 times, most recently
from
011df67 to
f17bf90
Compare
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that in the
SelectEmoteSetmodal, the "buttons" don't have any tooltip. This can make discovering the purpose of a button hard. In addition, all the buttons in this dialog aredivs. Furthermore, the modal isn't maked as a dialog/modal to the browser.This PR attempts to fix these issues while maintaining the style of the old buttons. With the core component being
UnstyledButtonthat, as the name suggests, is abuttonthat's styled like adiv.There's one more issue that's out of scope (i think): The dialog should have a focus trap, so elements behind it can't be tabbed. There's a hook in vueuse for it, but at this point why not use something likeElements behind the dialog cannot be tabbed now.@headlessui/vuewhich implements a plain, accessible dialog.The PR only modifies the
SelectEmoteSetdialog, future PRs could modify other dialog.