Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added reverse engineered ChatGPT API #96

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

lunjielee
Copy link

Hi, @SevaSk,

I hope you're doing well. I wanted to let you know about a PR that I've submitted. It introduces a new feature to ecoute, allowing users to utilize it without the need for a paid OpenAI account. Could you please take a look and provide your feedback?

Thanks,
Lunjie

@SevaSk
Copy link
Owner

SevaSk commented Jun 10, 2023

Hmm not sure its OK to merge since this is probably not legal. Also for design I prefer to follow the tell, don't ask principle. Here why are we asking if the revChatGPT flag is set every time we want generate a response? Wouldn't it be better to tell the class to override the different response generation functionally once at the beginning of the program instead? No need to complicate class with more flags.

@lunjielee
Copy link
Author

Hmm not sure its OK to merge since this is probably not legal. Also for design I prefer to follow the tell, don't ask principle. Here why are we asking if the revChatGPT flag is set every time we want generate a response? Wouldn't it be better to tell the class to override the different response generation functionally once at the beginning of the program instead? No need to complicate class with more flags.

With regards to the first question, are you stating that merging the code is prohibited due to license issues or the utilization of a reverse-engineered API?

Regarding the second question, you are absolutely right. It is preferable to adhere to the "tell, don't ask" principle. I will ensure to modify that section of the code accordingly.

Lunjie

@Rakshay-pawar
Copy link

Rakshay-pawar commented Dec 26, 2023

Hmm not sure its OK to merge since this is probably not legal. Also for design I prefer to follow the tell, don't ask principle. Here why are we asking if the revChatGPT flag is set every time we want generate a response? Wouldn't it be better to tell the class to override the different response generation functionally once at the beginning of the program instead? No need to complicate class with more flags.

Lunjie
Hi Lunjie I downloaded your files and replaced them with the original files however I am getting an error "ImportError: cannot import name 'ACCESS_TOKEN' from 'keys' (C:\Users\yahsk\Desktop\genesis\ecoute\ecoute\keys.py)"
With the original files it was working properly and was facing no issues. I have the keys.py file in the folder with my openAI access key and am calling "python main.py --revChatGPT"
Capture

@Rakshay-pawar
Copy link

Hi, @SevaSk,

I hope you're doing well. I wanted to let you know about a PR that I've submitted. It introduces a new feature to ecoute, allowing users to utilize it without the need for a paid OpenAI account. Could you please take a look and provide your feedback?

Thanks, Lunjie

Lunjie
Hi Lunjie I downloaded your files and replaced them with the original files however I am getting an error "ImportError: cannot import name 'ACCESS_TOKEN' from 'keys' (C:\Users\yahsk\Desktop\genesis\ecoute\ecoute\keys.py)"
With the original files it was working properly and was facing no issues. I have the keys.py file in the folder with my openAI access key and am calling "python main.py --revChatGPT"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants