Removed observability code. #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A Service Weaver application has logs, traces, and metrics. Before this PR, `weaver kube deploy` generated Kubernetes YAML to set up Prometheus, Jaegar, Grafana, and Loki. The `weaver kube` babysitter exported logs, traces, and metrics to these systems. However, there was no way for a user to customize how telemetry was handled. If you wanted to export traces to Datadog, for example, well, you couldn't. To address this problem in the long term, we're considering introducing a general purpose mechanism that would allow developers to customize deployers using a set of components. A metric exporting component, for example, would customize how metrics are exported. In the short term, we're going to introduce a much simpler and less general approach where a developer can plug in custom ways to manage telemetry. This also means that `weaver kube` no longer has to generate YAML to run Prometheus, Jaegar, and whatnot. Instead, they will be plugins.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Service Weaver application has logs, traces, and metrics. Before this PR,
weaver kube deploygenerated Kubernetes YAML to set up Prometheus, Jaegar, Grafana, and Loki. Theweaver kubebabysitter exported logs, traces, and metrics to these systems. However, there was no way for a user to customize how telemetry was handled. If you wanted to export traces to Datadog, for example, well, you couldn't.To address this problem in the long term, we're considering introducing a general purpose mechanism that would allow developers to customize deployers using a set of components. A metric exporting component, for example, would customize how metrics are exported.
In the short term, we're going to introduce a much simpler and less general approach where a developer can plug in custom ways to manage telemetry. This also means that
weaver kubeno longer has to generate YAML to run Prometheus, Jaegar, and whatnot. Instead, they will be plugins.