Put babysitter configuration in ConfigMap. #82
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, babysitter configuration was proto encoded, base64 encoded, and passed to the babysitter via environment variable. This PR instead puts the configuration in a ConfigMap:
The configuration includes the original
weaver.toml
file and aconfig.textpb
file that includes a prototext encodedBabysitterConfig
proto (which replacesReplicaSetConfig
). These files are mounted into the babysitter containers and passed to the babysitter as command line arguments:This change takes us a step closer to
weaver kube exec
, if that's something we end up doing. It also makes the generated YAML more readable and self-explanatory.