Don't use kube.proto in kube.go. #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwhittaker
force-pushed
the
strike_writers
branch
from
09e994a
to
57dc236
Compare
Previously, `ReplicaSetConfig` in `kube.proto` was used in two ways. It was serialized and passed to the babysitter, and it was used internally by `kube.go`. This PR refactors `kube.go` to use a `deployment` struct instead of a `ReplicaSetConfig`. This will enable me to simplify `ReplicaSetConfig` in a future PR.
mwhittaker
force-pushed
the
no_proto
branch
2 times, most recently
from
5f0d158
to
ac7cdb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
ReplicaSetConfiginkube.protowas used in two ways. It was serialized and passed to the babysitter, and it was used internally bykube.go. This PR refactorskube.goto use adeploymentstruct instead of aReplicaSetConfig. This will enable me to simplifyReplicaSetConfigin a future PR.