Refactored deployer code to unexport stuff. #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrandl
approved these changes
Oct 19, 2023
Thanks, me too! |
Previously, `impl.KubeConfig`, `impl.BuildAndUploadDockerImage`, and `impl.GenerateYAMLs` were all exported and used by `cmd/weaver-kube/deploy.go`. This PR moves the `deploy.go` code into `internal/impl/deploy.go` to unexport these things, and instead exports a single `Deploy` function. I also moved all user-provided config into a `config.go` file.
mwhittaker
force-pushed
the
unexport_stuff
branch
from
0b33e43
to
a01921b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
impl.KubeConfig,impl.BuildAndUploadDockerImage, andimpl.GenerateYAMLswere all exported and used bycmd/weaver-kube/deploy.go. This PR moves thedeploy.gocode intointernal/impl/deploy.goto unexport these things, and instead exports a singleDeployfunction.I also moved all user-provided config into a
config.gofile.