Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added annotations to generated resources. #73

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Added annotations to generated resources. #73

merged 2 commits into from
Oct 18, 2023

Conversation

mwhittaker
Copy link
Member 

$ kubectl get all -o custom-columns=KIND:.kind,NAME:.metadata.name,APP:.metadata.labels.appName,VERSION:.metadata.labels.version,DESCRIPTION:.metadata.annotations.description
KIND                      NAME                                              APP       VERSION    DESCRIPTION
Pod                       collatz-even-23e28c55-d4475a9c-7f445cb744-6rw78   collatz   <none>     This Pod hosts components collatz.Even, collatz.Odd.
Pod                       weaver-main-23e28c55-c91533b0-5c7dc8b98-5qdp5     collatz   <none>     This Pod hosts components weaver.Main.
Service                   collatz-23e28c55                                  <none>    23e28c55   This Service forwards traffic to the "collatz" listener.
Service                   kubernetes                                        <none>    <none>     <none>
Deployment                collatz-even-23e28c55-d4475a9c                    <none>    23e28c55   This Deployment hosts components collatz.Even, collatz.Odd.
Deployment                weaver-main-23e28c55-c91533b0                     <none>    23e28c55   This Deployment hosts components weaver.Main.
ReplicaSet                collatz-even-23e28c55-d4475a9c-7f445cb744         collatz   <none>     This Deployment hosts components collatz.Even, collatz.Odd.
ReplicaSet                weaver-main-23e28c55-c91533b0-5c7dc8b98           collatz   <none>     This Deployment hosts components weaver.Main.
HorizontalPodAutoscaler   collatz-even-23e28c55-d4475a9c                    <none>    23e28c55   This HorizontalPodAutoscaler scales the "collatz-even-23e28c55-d4475a9c" Deployment.
HorizontalPodAutoscaler   weaver-main-23e28c55-c91533b0                     <none>    23e28c55   This HorizontalPodAutoscaler scales the "weaver-main-23e28c55-c91533b0" Deployment.

@mwhittaker mwhittaker self-assigned this Oct 17, 2023
rgrandl
rgrandl approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@rgrandl rgrandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Can we add the kubectl command to see the annotations to the YAML header as well?

Base automatically changed from service_first to main October 18, 2023 16:25
@mwhittaker
Added annotations to generated resources.
b91598a 
```
$ kubectl get all -o custom-columns=KIND:.kind,NAME:.metadata.name,APP:.metadata.labels.appName,VERSION:.metadata.labels.version,DESCRIPTION:.metadata.annotations.description
KIND                      NAME                                              APP       VERSION    DESCRIPTION
Pod                       collatz-even-23e28c55-d4475a9c-7f445cb744-6rw78   collatz   <none>     This Pod hosts components collatz.Even, collatz.Odd.
Pod                       weaver-main-23e28c55-c91533b0-5c7dc8b98-5qdp5     collatz   <none>     This Pod hosts components weaver.Main.
Service                   collatz-23e28c55                                  <none>    23e28c55   This Service forwards traffic to the "collatz" listener.
Service                   kubernetes                                        <none>    <none>     <none>
Deployment                collatz-even-23e28c55-d4475a9c                    <none>    23e28c55   This Deployment hosts components collatz.Even, collatz.Odd.
Deployment                weaver-main-23e28c55-c91533b0                     <none>    23e28c55   This Deployment hosts components weaver.Main.
ReplicaSet                collatz-even-23e28c55-d4475a9c-7f445cb744         collatz   <none>     This Deployment hosts components collatz.Even, collatz.Odd.
ReplicaSet                weaver-main-23e28c55-c91533b0-5c7dc8b98           collatz   <none>     This Deployment hosts components weaver.Main.
HorizontalPodAutoscaler   collatz-even-23e28c55-d4475a9c                    <none>    23e28c55   This HorizontalPodAutoscaler scales the "collatz-even-23e28c55-d4475a9c" Deployment.
HorizontalPodAutoscaler   weaver-main-23e28c55-c91533b0                     <none>    23e28c55   This HorizontalPodAutoscaler scales the "weaver-main-23e28c55-c91533b0" Deployment.
```
@mwhittaker
Copy link
Member Author

Nice. Can we add the kubectl command to see the annotations to the YAML header as well?

Done.

@mwhittaker mwhittaker merged commit bcb9052 into main Oct 18, 2023
10 checks passed
@mwhittaker mwhittaker deleted the annotations branch October 18, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgrandl rgrandl rgrandl approved these changes

Assignees

@mwhittaker mwhittaker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mwhittaker @rgrandl