Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't generate any metrics bits if prometheus is disabled #65

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Don't generate any metrics bits if prometheus is disabled #65

merged 1 commit into from
Oct 10, 2023

Commits on Oct 10, 2023

  1. Don't generate any metrics bits if prometheus is disabled 

    If observability is completely disabled, we still add to the generated
k8s manifest file the metrics port on which we export metrics, and we
also create a label neede by prometheus to scrape the pods.

This PR disables generating such info unless prometheus is enabled.
    @rgrandl
    rgrandl committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    4fa6e19 View commit details
    Browse the repository at this point in the history