Generate new deployment for each app version #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwhittaker
approved these changes
Oct 6, 2023
internal/impl/kube.go
Outdated
| Strategy: appsv1.DeploymentStrategy{ | ||
| Type: "RollingUpdate", | ||
| RollingUpdate: &appsv1.RollingUpdateDeployment{}, | ||
| }, | ||
| // Number of old ReplicaSets to retain to allow rollback. | ||
| RevisionHistoryLimit: ptrOf(int32(1)), |
There was a problem hiding this comment.
Can we delete RevisionHistoryLimit and MinReadySeconds now too?
There was a problem hiding this comment.
Good point about 'RevisionHistoryLimit. As for MinReadySeconds` I think it still makes sense, but I guess we can let someone configure it if they really want so we set less knobs in the config.
In the current implementation, we generate new deployments for each replica set other than the one that has the public listeners (e.g., main). When we rollout a new version of the app, we do rolling upgrade on the main group, hence we can do automated rollouts. However, this approach is not great and it doesn't make sense for someone to do this in production. For development/testing, someone can simply start a new app deployment and kill the old one. This PR changes the deployment such that: * we now generate unique deployments for all groups (including main) * we generate unique name for the listener service iff the user wants that; this allows the user to reuse the same listener across multiple app versions - makes it easy to do port-forwarding, curl the same IP, etc. * we added a "version" label to the deployments/HPAs/listeners, s.t., we can easily delete old deployments; e.g., `kubectl delete all --selector=version=foo` deletes all the k8s resources for the app version foo.
rgrandl
force-pushed
the
remove_rollouts
branch
from
34bf4ca
to
6f33c54
Compare
rgrandl
commented
Oct 6, 2023
internal/impl/kube.go
Outdated
| Strategy: appsv1.DeploymentStrategy{ | ||
| Type: "RollingUpdate", | ||
| RollingUpdate: &appsv1.RollingUpdateDeployment{}, | ||
| }, | ||
| // Number of old ReplicaSets to retain to allow rollback. | ||
| RevisionHistoryLimit: ptrOf(int32(1)), |
There was a problem hiding this comment.
Good point about 'RevisionHistoryLimit. As for MinReadySeconds` I think it still makes sense, but I guess we can let someone configure it if they really want so we set less knobs in the config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation, we generate new deployments for each replica set other than the one that has the public listeners (e.g., main). When we rollout a new version of the app, we do rolling upgrade on the main group, hence we can do automated rollouts.
However, this approach is not great and it doesn't make sense for someone to do this in production. For development/testing, someone can simply start a new app deployment and kill the old one.
This PR changes the deployment such that:
kubectl delete all --selector=version=foodeletes all the k8s resources for the app version foo.